Fix return version tests #1295
Merged
Fix return version tests #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of ongoing work to remove database cleans from the test suit we are getting intermittent tests failing mainly due to unique constraints where the range is too small to ensure uniqueness. This change adds a generate random region code function explaining the issue. The aim of this change is to encapsulate the issue and remove any need to explain the issue else where in the tests.
jonathangoulding
added
bug
As part of ongoing work to remove database cleans from the test suit we are getting intermittent tests failing mainly due to unique constraints where the range is too small to ensure uniqueness. This change adds a generate random region code function explaining the issue. The aim of this change is to encapsulate the issue and remove any need to explain the issue else where in the tests.
As part of ongoing work to remove database cleans from the test suit we are getting intermittent tests failing mainly due to unique constraints where the range is too small to ensure uniqueness. This change adds a generate random region code function explaining the issue. The aim of this change is to encapsulate the issue and remove any need to explain the issue else where in the tests.
jonathangoulding
requested review from
Cruikshanks,
Beckyrose200,
robertparkinson,
Jozzey and
rvsiyad
and removed request for
Cruikshanks
Cruikshanks
requested changes
Aug 30, 2024
Co-authored-by: Alan Cruikshanks <[email protected]>
robertparkinson
approved these changes
Aug 30, 2024
Cruikshanks
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of ongoing work to remove database cleans from the test suit we are getting intermittent tests failing mainly due to unique constraints where the range is too small to ensure uniqueness.
This change adds a generate random region code function explaining the issue.
The aim of this change is to encapsulate the issue and remove any need to explain the issue else where in the tests.