Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger 2PT Supplementary Bill Run - Pt2 #1262

Merged
merged 34 commits into from
Sep 5, 2024
Merged

Conversation

Jozzey
Copy link
Contributor

@Jozzey Jozzey commented Aug 16, 2024

https://eaflood.atlassian.net/browse/WATER-4631

As we treat 2PT supplementary as a separate bill run we will need a new journey to trigger it.

The first part of this work was carried out in PR #1259

In this PR the remainder of the journey to enable the triggering of a 2PT supplementary will be completed. This will include selecting the required financial year and triggering the bill run.

https://eaflood.atlassian.net/browse/WATER-4631

As we are treating 2PT supplementary as a separate bill run we will need a new journey to trigger it.

The first part of this work was carried on in PR #1259

In this PR the remainder of the journey to enable triggering of a 2PT supplementary will be completed. This will include selecting the required financial year and triggering the bill run.
@Jozzey Jozzey added the enhancement New feature or request label Aug 16, 2024
@Jozzey Jozzey self-assigned this Aug 16, 2024
@Jozzey Jozzey marked this pull request as ready for review August 29, 2024 17:42
The values that come out of the view when submitted will always be strings regardless if they are coded as numbers. Therefore we've decided that it will make things cleaner to convert the numeric values to strings when they are pulled out of the database.
@Jozzey Jozzey requested a review from Beckyrose200 August 30, 2024 13:25
@Jozzey Jozzey requested a review from Beckyrose200 September 2, 2024 17:18
Copy link
Contributor

@Beckyrose200 Beckyrose200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good some small comments

app/services/bill-runs/setup/year.service.js Show resolved Hide resolved
app/services/bill-runs/setup/year.service.js Outdated Show resolved Hide resolved
app/services/bill-runs/setup/year.service.js Outdated Show resolved Hide resolved
app/services/bill-runs/setup/submit-year.service.js Outdated Show resolved Hide resolved
@Jozzey Jozzey requested a review from Beckyrose200 September 4, 2024 15:32
Copy link
Contributor

@Beckyrose200 Beckyrose200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jozzey Jozzey merged commit d0d7442 into main Sep 5, 2024
6 checks passed
@Jozzey Jozzey deleted the trigger-tpt-supp-bill-run-pt2 branch September 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants