-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger 2PT Supplementary Bill Run - Pt2 #1262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4631 As we are treating 2PT supplementary as a separate bill run we will need a new journey to trigger it. The first part of this work was carried on in PR #1259 In this PR the remainder of the journey to enable triggering of a 2PT supplementary will be completed. This will include selecting the required financial year and triggering the bill run.
The test I have added is a temporary one that will be removed once there is a two-part tariff supplementary process built.
The values that come out of the view when submitted will always be strings regardless if they are coded as numbers. Therefore we've decided that it will make things cleaner to convert the numeric values to strings when they are pulled out of the database.
Beckyrose200
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good some small comments
Beckyrose200
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4631
As we treat 2PT supplementary as a separate bill run we will need a new journey to trigger it.
The first part of this work was carried out in PR #1259
In this PR the remainder of the journey to enable the triggering of a 2PT supplementary will be completed. This will include selecting the required financial year and triggering the bill run.