Fix order of return versions in view licence #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4407 > Part of the work to replace NALD for handling return requirements Spotted in testing is that if a licence has 2 return versions with the same start date (one will be 'approved' and the other will display as 'replaced'), it is possible that they will be ordered incorrectly. In this scenario, the 'approved' should be first in the table and then the 'replaced'. We had exactly the [same issue with charge versions](#1162). The solution was to order them first by start date, then by version number. So, we apply the same sorting to when we fetch the return versions.
Cruikshanks
force-pushed
the
fix-order-of-return-versions
branch
from
bd1cdda to
125a17c
Compare
Cruikshanks
requested review from
robertparkinson,
sujithvg,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4407
Spotted in testing is that if a licence has 2 return versions with the same start date (one will be 'approved' and the other will display as 'replaced'), it is possible that they will be ordered incorrectly. In this scenario, the 'approved' should be first in the table, followed by 'replaced'.
We had exactly the same issue with charge versions. The solution was to order them first by start date, then by version number. So, we apply the same sorting to when we fetch the return versions.
Before
After