Fix all remaining lint issues #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of ongoing automation for our code practices and preferences we introduced eslint instead of the DEFRA standard linter standard.js. Our eslint setup uses standard.js as the base linter but we have our own rules on top. We have previously introduced a gradual adoption of eslint by using the git diff when running eslint. This appears to have some limitation with some rules not getting picked up. At this point it makes sense to fix the remaining lint issues and remove the git diff and lint the whole codebase. When we first moved over to eslint there were 1000+ issues now we only have 137 issues (with the majority being able to be fixed with --fix). This change fixes all outstanding linting issues and remove the previous lint with git diff lint to the basic eslint run.
jonathangoulding
added
the
housekeeping
jonathangoulding
requested review from
Cruikshanks,
Jozzey and
Beckyrose200
and removed request for
Cruikshanks and
Jozzey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#115
As part of ongoing automation for our code practices and preferences we introduced eslint instead of the DEFRA standard linter standard.js.
Our eslint setup uses standard.js as the base linter but we have our own rules on top.
We have previously introduced a gradual adoption of eslint by using the git diff when running eslint. This appears to have some limitation with some rules not getting picked up.
At this point it makes sense to fix the remaining lint issues and remove the git diff and lint the whole codebase. When we first moved over to eslint there were 1000+ issues now we only have 137 issues (with the majority being able to be fixed with --fix).
This change fixes all outstanding linting issues and remove the previous lint with git diff lint to the basic eslint run.