Generate return logs from requirements #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EFRA/water-abstraction-system into generate-return-logs-from-requirements
…EFRA/water-abstraction-system into generate-return-logs-from-requirements
…EFRA/water-abstraction-system into generate-return-logs-from-requirements
…EFRA/water-abstraction-system into generate-return-logs-from-requirements
Cruikshanks
requested changes
Aug 22, 2024
There was a problem hiding this comment.
To help keep things moving I'll flit between the two 🦣 PR's with quick bits of feedback and suggested changes.
So, I still need to go through the rest. But figured this is something that could be looked at whilst I take a chunk out of @jonathangoulding 's PR!
…EFRA/water-abstraction-system into generate-return-logs-from-requirements
Cruikshanks
requested changes
Aug 27, 2024
Cruikshanks
requested changes
Aug 27, 2024
test/services/jobs/return-logs/process-return-logs.service.test.js
Outdated
Show resolved
Hide resolved
test/services/jobs/return-logs/process-return-logs.service.test.js
Outdated
Show resolved
Hide resolved
…EFRA/water-abstraction-system into generate-return-logs-from-requirements
Cruikshanks
requested changes
Aug 27, 2024
Cruikshanks
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4543
As part of the work to replace the legacy system NALD we need to generate return logs. This PR creates a job that when run twice a year will create the return logs for the appropriate cycle, either summer or winter/all year.