Create SROC two-part tariff flagging endpoint for new charge versions #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4622 This is apart of the work for two-part tariff supplementary billing. A licence can be added to a two-part tariff supplementary bill run in 5 ways. Editing a return, adding a historic charge version, removing a licence from the annual two-part tariff bill run, recalculate a bill and if a licence is lapsed or revoked. Out of these 5 ways, 4 of them are in the legacy code base. To keep the new code for the supplementary billing within our system code base, we have decided to create a new endpoint that the legacy code can hit to calculate if the changed licence needs to be added to a supplementary bill run. This PR is setting up the endpoint.
Co-authored-by: Jason Claxton <[email protected]>
Beckyrose200
changed the title
Cruikshanks
requested changes
Aug 13, 2024
app/services/licences/check-supplementary-billing-flag.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/check-supplementary-billing-flag.service.js
Outdated
Show resolved
Hide resolved
Beckyrose200
added a commit
to DEFRA/water-abstraction-service
that referenced
this pull request
Aug 15, 2024
DEFRA/water-abstraction-system#1239 During recent refactoring for the Supplementary billing flag process, the route was updated to better reflect the naming conventions in the repo. This PR is to update the routes when the service is called.
Beckyrose200
added a commit
to DEFRA/water-abstraction-service
that referenced
this pull request
Aug 16, 2024
DEFRA/water-abstraction-system#1239 During recent refactoring for the Supplementary billing flag process, the route was updated to better reflect the naming conventions in the repo. This PR is to update the routes when the service is called.
Cruikshanks
requested changes
Aug 16, 2024
test/services/licences/supplementary/determine-charge-version-years.service.test.js
Outdated
Show resolved
Hide resolved
test/services/licences/supplementary/process-billing-flag.service.test.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4622
https://eaflood.atlassian.net/browse/WATER-4588
This is a part of the work for two-part tariff supplementary billing. A licence can be added to a two-part tariff supplementary bill run in 5 ways. Editing a return, adding a historic charge version, removing a licence from the annual two-part tariff bill run, recalculating a bill and if a licence is lapsed or revoked.
Out of these 5 ways, 4 of them are in the legacy code base. To keep the new code for the supplementary billing within our system code base, we have decided to create a new endpoint that the legacy code can hit to calculate if the changed licence needs to be added to a supplementary bill run. This PR sets up the endpoint and flags a licence in need of a supplementary bill run when a historic charge version is added.