Update acceptance test tear down service #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-acceptance-tests#129 During the removal of region data in our acceptance test fixture file, it was noted that the new region seeder was breaking our tear down service. The tear down service relies on knowing if the region associated with the data is a test region or not through the 'isTest' property. The seeded test region has this set to false, when it needs to be true. This also means updating this data then deletes the test region itself at the end of ever tear down, so this PR is to update the region seeder and the tear down service.
Beckyrose200
requested review from
Cruikshanks,
robertparkinson,
sujithvg,
Jozzey,
jonathangoulding and
rvsiyad
Cruikshanks
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-acceptance-tests#129
During the removal of our region data in the acceptance tests, it was noted that the new region seeder was being deleted in the tear-down service. The tear-down service relies on knowing if the region associated with the data is a test region or not through the 'isTest' property. After deleting the associated data with the test region it then deletes the region itself. As our region is now seeded and not being loaded fo every test, this last delete needs to be removed.
This PR is removing that.