-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix region seeder name #1233
Fix region seeder name #1233
Conversation
A naught fella has been left in the code. This should be removed
Unless it is urgent, this was spotted and will be resolved by #1230 |
This should be breaking tests - but i think they are testing the display name and not the name. So maybe not urgent if the next work is going in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change it for the test region, so it sets the isTest
column to true? The tear-down service for the acceptance tests utilises the test region isTest
property to know what data to delete and with the seeder test region the tear-down is breaking
You would need to update the data file and columns. Maybe set the default to false allow the data file to override. Might be worth a check on the PR mentioned if that's considered this. |
Parking this as we have #1230 incoming. It also deals with @Beckyrose200 question about flagging the region as |
Closing as covered by #1230 |
A naught fella has been left in the code. This should be removed