Return version can be on/after licence start date #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4599 Currently, when a user reaches the start date page for either the 'no returns required' or 'set up new requirements' journey, and enters a start date before the return version start date, the system errors. A fix needs to be put in place to allow users to enter a start date that is on or after the licence start date. This PR will change the validation to allow users to enter a start that can proceed the return version start date but is on or after the licence start date.
… allowed for the return
rvsiyad
requested review from
Cruikshanks,
robertparkinson,
sujithvg,
Jozzey,
jonathangoulding and
Beckyrose200
Cruikshanks
requested changes
Aug 1, 2024
…he licence start date
…FRA/water-abstraction-system into return-requirement-start-date
Cruikshanks
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4599
Currently, when a user reaches the start date page for either the 'no returns required' or 'set up new requirements' journey, and enters a start date before the return version start date, the system errors. A fix needs to be put in place to allow users to enter a start date that is on or after the licence start date.
This PR will change the validation to allow users to enter a start that can proceed the return version start date but is on or after the licence start date.