Remove DatabaseSupport.clean() from bill-licences #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#124 We had a pattern of calling `await DatabaseSupport.clean()` in a `beforeEach()` in any unit test file that depended on adding data to support its tests. The problem is that the project is becoming so large that it is no longer sustainable. It is also a blocker to moving to a test framework that supports [ECMAScript Modules](https://nodejs.org/api/esm.html), [the official standard format](https://tc39.github.io/ecma262/#sec-modules) to package JavaScript code. Unit test frameworks other than [Hapi Lab](https://hapi.dev/module/lab/) run tests in parallel by default. This means you can't have one test running DB clean while another is trying to load data. New tests avoid the pattern, and where we can we've been updating old ones when we have had cause to update the unit tests. But there are always those where it'll be some time before we have cause to look at them again. So, rather than waiting this change handles updating all tests in `test/services/bill-licences` to drop their dependence on `DatabaseSupport.clean()`.
Cruikshanks
added
the
housekeeping
Cruikshanks
requested review from
robertparkinson,
sujithvg,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#124
We had a pattern of calling
await DatabaseSupport.clean()in abeforeEach()in any unit test file that depended on adding data to support its tests.The problem is that the project is becoming so large that it is no longer sustainable. It is also a blocker to moving to a test framework that supports ECMAScript Modules, the official standard format to package JavaScript code. Unit test frameworks other than Hapi Lab run tests in parallel by default. This means you can't have one test running DB clean while another is trying to load data.
New tests avoid the pattern, and where we can, we've been updating old ones when we have had cause to update the unit tests.
But there are always those where it'll be some time before we have cause to look at them again. So, rather than waiting, this change handles updating all tests in
test/services/bill-licencesto drop their dependence onDatabaseSupport.clean().