Deleted agreements shouldn't show in the setup tab

[rvsiyad]

https://eaflood.atlassian.net/browse/WATER-4604

Currently, when an agreement is deleted within the licence set up tab, the agreement still remains. This is because the agreement is being 'soft deleted' rather than being removed from the database completely by adding the current time and date to the 'deleted_at' column in the licence agreements table. The logic for pulling licence agreements is missing instructions to only show licence agreements where the 'deleted_at' is null.

This PR is focused on not showing licence agreements in the licence set up tab where the licence has the 'deleted_at' column populated.

[Jozzey]

Spotted another issue you have with the tests on this. We are no longer adding await DatabaseSupport.clean() to any of our unit tests unless we really need to so this needs to be removed from your tests. When you do that your tests are going to break. This is because the financialAgreement id is hardcoded. There is no need to hardcode any of the FinancialAgreementHelper data, it will generate random data for this which is fine for these tests.

You also have the licenceRef hardcoded. You should let theLicenceAgreementHelper generate this and have it declared as a let rather than a const and then update the licenceRef variable when you generate the record with the helper.

Let me know if you want me to go through this with you.

[rvsiyad]

Spotted another issue you have with the tests on this. We are no longer adding await DatabaseSupport.clean() to any of our unit tests unless we really need to so this needs to be removed from your tests. When you do that your tests are going to break. This is because the financialAgreement id is hardcoded. There is no need to hardcode any of the FinancialAgreementHelper data, it will generate random data for this which is fine for these tests.

You also have the licenceRef hardcoded. You should let theLicenceAgreementHelper generate this and have it declared as a let rather than a const and then update the licenceRef variable when you generate the record with the helper.

Let me know if you want me to go through this with you.

Think i've got it working fine now, let me know if i should change the names for the variables to have a Data prefix for clarity e.g. let financialAgreementData

[Jozzey]

Sorry, Spotted another couple of things while on a call. That should be it this time though!

Up to you if you want to rename the variables to things like let financialAgreementData. I'm fine with them as they are.

[Jozzey]