Refactor the existing purpose condition types to be consistent #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of migrating the import service into the wabs system repo we are adding seeders to the tests which will add what we call reference data the test database. This is currently running and adding other seeders in the test database. This change aligns the licence version purpose condition type seeder. Mainly using a data file for us to access this static data in the tests and using the build value string function to build the values to insert into the database. https://eaflood.atlassian.net/browse/WATER-4535
Cruikshanks
approved these changes
Jul 31, 2024
jonathangoulding
deleted the
refactor-licence-version-purpose-contdition-type-seeder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4535
As part of migrating the import service into the wabs system repo we are adding seeders to the tests which will add what we call reference data the test database.
This is currently running and adding other seeders in the test database.
This change aligns the licence version purpose condition type seeder. Mainly using a data file for us to access this static data in the tests and using the build value string function to build the values to insert into the database.