Two-part tariff due returns to show as blank #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4606 During testing for the two-part tariff review pages, it was raised that the billing and data team wanted to amend the returns displaying under a charge element. Currently when a return matches to a charge element, we show these under the charge element with there allocated quantity. This means for a return that is due the quantity displayed is always 0. The billing and data team would like to remove this and show a due return as being blank instead of 0. They say that showing 0 gives the false impression that the return is a nil return, rather then a due return. This PR is for this change.
Beckyrose200
requested review from
robertparkinson,
jonathangoulding and
rvsiyad
robertparkinson
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4606
During testing for the two-part tariff review pages, it was raised that the billing and data team wanted to amend the returns displaying under a charge element. When a return matches a charge element, we show these under the review charge element section with their allocated quantity.
A due return currently displays
0 ML. The billing and data team wants to remove this and show a due return as blank instead of0 ML. They say that showing0 MLgives the false impression that the return is a nil return, rather than a due return. This PR is for this change.