Add region test seeder #1193
Merged
Add region test seeder #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4575 The public.regions table is what we call reference data. We assume this table will not change frequently, if ever. As part of the work to replace the legacy import service we have decided to seed any data we have deemed reference data. We will use these seeders in testing. We need to add this now as the nald region id when randomly generated is between 1-8. This was causing random test failures when using the normal RegionHelper.add(). This was found because we have moved away from clearing the database before each test and having a pre test clean the database instead. (This is previous work to allow us to potentially speed up the tests and change our test framework)
jonathangoulding
force-pushed
the
add-region-helper-seeder
branch
from
23325fc to
eed9190
Compare
|
I have tested against the acceptance tests and they are working. They will either create there own new region or update the region. |
robertparkinson
approved these changes
Jul 16, 2024
jonathangoulding
added a commit
that referenced
this pull request
Jul 24, 2024
…is table will not change frequently, if ever. As part of the work to replace the legacy import service we have decided to seed any data we have deemed reference data. We will use these seeders in testing. We need to add this now as the nald region id when randomly generated is between 1-8. This was causing random test failures when using the normal RegionHelper.add(). This was found because we have moved away from clearing the database before each test and having a pre test clean the database instead. (This is previous work to allow us to potentially speed up the tests and change our test framework) https://eaflood.atlassian.net/browse/WATER-4575 Old region seeder - #1193 Updated seeder pattern - #1206
Merged
jonathangoulding
added a commit
that referenced
this pull request
Jul 25, 2024
* The public.regions table is what we call reference data. We assume this table will not change frequently, if ever. As part of the work to replace the legacy import service we have decided to seed any data we have deemed reference data. We will use these seeders in testing. We need to add this now as the nald region id when randomly generated is between 1-8. This was causing random test failures when using the normal RegionHelper.add(). This was found because we have moved away from clearing the database before each test and having a pre test clean the database instead. (This is previous work to allow us to potentially speed up the tests and change our test framework) https://eaflood.atlassian.net/browse/WATER-4575 Old region seeder - #1193 Updated seeder pattern - #1206 * fix: broken test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4575
The public.regions table is what we call reference data. We assume this table will not change frequently, if ever.
As part of the work to replace the legacy import service we have decided to seed any data we have deemed reference data.
We will use these seeders in testing. We need to add this now as the nald region id when randomly generated is between 1-8. This was causing random test failures when using the normal RegionHelper.add().
This was found because we have moved away from clearing the database before each test and having a pre test clean the database instead. (This is previous work to allow us to potentially speed up the tests and change our test framework)