Fix duplicate purposes in return reqs. set up #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4592 > Part of the return requirements set up work During the return requirements set up journey, users need to select at least one purpose for each return requirement they are setting up. The purposes they can choose from are only those linked to the current version of the licence. The issue found is that if a licence is linked to a purpose and then to a point, then the same purpose again but to a different point (perhaps because it has condition or different abstraction properties), it causes our logic to return the same purpose twice. More if things are really complicated! This change fixes it so that the user only sees a distinct list of applicable purposes on the 'Select the purpose for the requirements for returns' page.
Better matches how we have named other services.
Cruikshanks
force-pushed
the
fix-duplication-in-return-req-purposes
branch
from
1b19572 to
13aa8c5
Compare
Was looking at the wrong purpose ID.
The INNER JOIN was the root cause of the problem. Replacing that with an EXISTS solves it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4592
During the return requirements set up journey, users need to select at least one purpose for each return requirement they are setting up. The purposes they can choose from are only those linked to the current version of the licence.
The issue found is that if a licence is linked to a purpose and then to a point, then the same purpose again but to a different point (perhaps because it has condition or different abstraction properties), it causes our logic to return the same purpose twice. More if things are really complicated!
This change fixes it so that the user only sees a distinct list of applicable purposes on the 'Select the purpose for the requirements for returns' page.