Fix workflow start date in view licence set up tab #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4556 In testing of the new view licence page, specifically the licence set up tab, it was spotted that when a charge version has a status of `REVIEW` that the date the record was created rather than the start date is displayed in the charge information table. We fixed that in [Fix dates in view licence set up tab](#1175). But hot on its heels someone has pointed out the same applies for a workflow record with a status of `changes_requested`. So, this change fixes it so we display the charge version start date for a workflow record with a status of `changes_requested` in the charge information table of the Licence setup tab in our new view licence page.
This changes updates the status tags for charge versions (including workflow) and return versions so that - they only expect what we actually store in the DB (these are custom types so can only be these values) - that the tag macros follow the convention we've used in others We also split out the tag handling for return and charge versions to make it easier to see what we would expect to handle and to give us more flexibility should that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4556
In testing of the new view licence page, specifically the licence set up tab, it was spotted that when a charge version has a status of
REVIEWthat the date the record was created rather than the start date is displayed in the charge information table.We fixed that in Fix dates in view licence set up tab. But hot on its heels, someone has pointed out that the same applies for a workflow record with a status of
changes_requested.So, this change fixes it, so we display the charge version start date for a workflow record with a status of
changes_requestedin the charge information table of the Licence setup tab in our new view licence page.Because this meant looking at another workflow status, we needed to check that everything was linked up for
changes_requested. This led us to take another look at how the status for each record type in the tab was being determined. We decided to split the types to give us more flexibility and use the same convention we've used in other tags, i.e. pass the record status through and let the macro handle the display.So, a change to our tag macros was also made in this change.