Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tear down service #1174

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Update tear down service #1174

merged 10 commits into from
Jul 10, 2024

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-4450

Following on from writing the acceptance test for the two-part tariff review processed, we realised our tear-down service doesn't include the new tables created for the two-part tariff review. This PR is updating the tear-down service to add in those tables. This means all the data created from running the acceptance tests gets deleted.

https://eaflood.atlassian.net/browse/WATER-4450

Following on from writing the acceptance test for the two-part tariff review processed, we realised our tear down service doesn't include the new tables created for the two-part tariff review. This PR is updating the tear down service to add in those tables. This just means all the data created from running the acceptance tests gets deleted.
@Beckyrose200 Beckyrose200 added the enhancement New feature or request label Jul 9, 2024
@Beckyrose200 Beckyrose200 self-assigned this Jul 9, 2024
@Beckyrose200 Beckyrose200 marked this pull request as ready for review July 9, 2024 15:30
@Beckyrose200 Beckyrose200 marked this pull request as draft July 9, 2024 15:45
@Beckyrose200 Beckyrose200 marked this pull request as ready for review July 9, 2024 15:48
@Beckyrose200 Beckyrose200 requested a review from Jozzey July 10, 2024 10:01
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop all the trigger stuff.

app/services/data/tear-down/public-schema.service.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beckyrose200 Beckyrose200 requested a review from Cruikshanks July 10, 2024 10:17
@Beckyrose200 Beckyrose200 merged commit 3f60b65 into main Jul 10, 2024
6 checks passed
@Beckyrose200 Beckyrose200 deleted the update-tear-down-service branch July 10, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants