Fix order of charge vers. in view licence - again! #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4556 > Part of the work to replace the legacy view licence page We thought we'd nailed the ordering of the charge versions in the new licence setup tab of our new view licence screen in [Fix order of charge versions in view licence page](#1162). However, it's still not quite right. The previous fix assumed a 'superseded' charge version would always have an end date. However, it turns out this is not always the case. If followed by a 'current' charge version that also has an end date (because another has been added after it), sorting by end date means the 'current' comes after the 'superseded'. Having double checked the legacy code they have are sorting by start date then version number. As it is the legacy view's order we're trying to match, we're just going to crack on and make the change to do the same thing.
Cruikshanks
force-pushed
the
fix-charge-version-order-attempt-2
branch
from
8ace490 to
492b5cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4556
We thought we'd nailed the ordering of the charge versions in the new licence setup tab of our new view licence screen in Fix order of charge versions in view licence page.
However, it's still not quite right. The previous fix assumed a 'superseded' charge version would always have an end date. However, it turns out this is not always the case. If followed by a 'current' charge version that also has an end date (because another has been added after it), sorting by end date means the 'current' comes after the 'superseded'.
Having double-checked the legacy code, they are sorting by start date, then version number. As it is the legacy view's order we're trying to match, we're just going to crack on and make the change to do the same thing.