-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix route handler property to follow same pattern #1155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#122 We have noticed that in some of our routes, the `handler` is within the `options property`. ```javascript { method: 'POST', path: '/bills/{id}/remove', options: { handler: BillsController.submitRemove, auth: { access: { scope: ['billing'] } } } } ``` Whilst in others it is outside: ```javascript { method: 'GET', path: '/bill-runs', handler: BillRunsController.index, options: { auth: { access: { scope: ['billing'] } } } } ``` This is as a result of some contraction between the [Hapi API documentation](https://hapi.dev/api/?v=21.3.3#-routeoptionshandler) having the `handler` within the `options` property, and the [Hapi Tutorial](https://hapi.dev/tutorials/routing/?lang=en_US) giving examples with the `handler` outside the `options` property. The decision has been made to follow the API documentation. This PR is focused on going through the routes files and ensuring the `handler` is within the `options` property.
rvsiyad
added
the
housekeeping
Refactoring, tidying up or other work which supports the project
label
Jul 2, 2024
…er-abstraction-system into correct-route-handlers
Cruikshanks
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#122
We have noticed that in some of our routes, the
handler
is within theoptions
property.Whilst in others it is outside:
This is as a result of some contradiction between the Hapi API documentation having the
handler
within theoptions
property, and the Hapi Tutorial giving examples with thehandler
outside theoptions
property. The decision has been made to follow the API documentation.This PR is focused on going through the routes files and ensuring the
handler
is within theoptions
property.