Display msg for multiple abs amounts in view #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4333 > Part of the work to replace the legacy view licence page When we first built our version of the view licence page's summary tab we applied the same logic when it came to a licence with multiple purposes; don't display abstraction amounts! This is because the amounts could be different across the purposes and you can't just sum them. It is possible that the total amount of abstraction might be different on the licence when compared to the sum of its purposes (welcome to water abstraction!) The old logic therefore hid the field. But we know anecdotally some users say you cannot see abstraction amounts in WRLS because of this behaviour. So, in this change when a licence has multiple purposes we'll instead show a message and a link to the screen which shows the amounts for each purpose. Where a licence has one purpose, we'll continue to display the amounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4333
When we first built our version of the view licence page's summary tab, we applied the same logic when it came to a licence with multiple purposes: don't display abstraction amounts!
This is because the amounts could be different across the purposes and you can't just sum them. It is possible that the total amount of abstraction might be different on the licence when compared to the sum of its purposes (welcome to water abstraction!)
The old logic therefore hid the field. But we know anecdotally some users say you cannot see abstraction amounts in WRLS because of this behaviour.
So, in this change, when a licence has multiple purposes, we'll instead show a message and a link to the screen that shows the amounts for each purpose. Where a licence has one purpose, we'll continue to display the amounts.