Fetch conditions from licence summary service #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4322 > Part of the work to replace the legacy view licence page The `ViewLicenceSummaryService` is calling `FetchLicenceAbstractionConditionsService` and `FetchLicenceSummaryService` and then passing both results to the presenter. Having checked, it is the only service using `FetchLicenceAbstractionConditionsService` and we don't really need the data preparation it is doing. If the relationship was added between `LicenceVersionPurposeModel` and `LicenceVersionPurposeConditionModel` we could get everything we need from the `FetchLicenceSummaryService`! So, this change makes that so.
Cruikshanks
added
the
housekeeping
It wasn't need in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4322
The
ViewLicenceSummaryServiceis callingFetchLicenceAbstractionConditionsServiceandFetchLicenceSummaryServiceand then passing both results to the presenter.Having checked, it is the only service using
FetchLicenceAbstractionConditionsServiceand we don't really need the data preparation it is doing.If the relationship was added between
LicenceVersionPurposeModelandLicenceVersionPurposeConditionModelwe could get everything we need from theFetchLicenceSummaryService!So, this change makes that so.