Enhance the padding-line lint rules

.eslintrc.js

@@ -20,12 +20,16 @@ module.exports = {
     '@stylistic/js/padding-line-between-statements': [
       'error',
       { blankLine: 'always', prev: '*', next: 'block' },
-      { blankLine: 'always', prev: '*', next: 'expression' },
       { blankLine: 'always', prev: '*', next: 'return' },
       { blankLine: 'always', prev: 'block', next: '*' },
       { blankLine: 'always', prev: 'block', next: 'function' },
-      { blankLine: 'always', prev: 'expression', next: '*' },
-      { blankLine: 'always', prev: 'function', next: '*' }
+      { blankLine: 'always', prev: 'function', next: '*' },
+      // blank lines after every sequence of variable declarations
+      { blankLine: 'always', prev: ['const', 'let', 'var'], next: '*' },
+      { blankLine: 'any', prev: ['const', 'let', 'var'], next: ['const', 'let', 'var'] },
+      // blank lines after all directive prologues e.g. 'use strict'
+      { blankLine: 'always', prev: 'directive', next: '*' },
+      { blankLine: 'any', prev: 'directive', next: 'directive' }
     ],
     'arrow-body-style': ['error', 'always'],
     'import/extensions': ['error', 'always'],

app/controllers/root.controller.js

@@ -8,6 +8,7 @@
 function index (_request, _h) {
   return { status: 'alive' }
 }
+
 module.exports = {
   index
 }

app/presenters/base.presenter.js

@@ -255,6 +255,7 @@ function titleCase (value) {
 
   words.forEach((word) => {
     const titleCasedWord = word.charAt(0).toUpperCase() + word.slice(1)
+
     titleCasedWords.push(titleCasedWord)
   })
 

app/presenters/bill-runs/two-part-tariff/review-bill-run.presenter.js

@@ -30,6 +30,7 @@ function go (billRun, filterIssues, filterLicenceHolderNumber, filterLicenceStat
   const issues = filterIssues ? _prepareIssues(filterIssues) : filterIssues
 
   const filter = { issues, licenceHolderNumber: filterLicenceHolderNumber, licenceStatus: filterLicenceStatus }
+
   // this opens the filter on the page if any filter data has been received so the user can see the applied filters
   filter.openFilter = (filterIssues || filterLicenceHolderNumber || filterLicenceStatus) !== undefined
 

app/presenters/licences/set-up.presenter.js

@@ -157,10 +157,12 @@ function _endsSixYearsAgo (endDate) {
   const timeStamp = { hour: 23, minutes: 59, seconds: 59, ms: 999 }
 
   const yesterday = new Date()
+
   yesterday.setDate(yesterday.getDate() - 1)
   yesterday.setHours(timeStamp.hour, timeStamp.minutes, timeStamp.seconds, timeStamp.ms)
 
   const sixYearsFromYesterday = new Date(yesterday.getTime())
+
   sixYearsFromYesterday.setFullYear(yesterday.getFullYear() - sixYears)
 
   return endDate.date < sixYearsFromYesterday