Fix default licence view createdBy #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/jira/software/c/projects/WATER/boards/96?selectedIssue=WATER-4422 When a return version does not have a user linked to the record the default string should be "Migrated from NALD". The assumption is a user can not create a return unless they are logged in. When the return is saved the user will be captured and stored in the createBty column. Therefore, if the created by field is null then it is safe to assume the data has been migrated from NALD.
Cruikshanks
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Only thing to point out is to do with the PR description
- there is a simplified JIRA link that can be used (not affected by changes to boards) https://eaflood.atlassian.net/browse/WATER-4422
- you have a typo;
createBty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4422
When a return version does not have a user linked to the record the default string should be "Migrated from NALD".
The assumption is a user can not create a return unless they are logged in. When the return is saved the user will be captured and stored in the createdBy column. Therefore, if the created by field is null then it is safe to assume the data has been migrated from NALD.