Persist a new return version and its requirements #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4519 Having completed the return requirements setup journey (returns-required), we need to persist both the return version (start date, reason and notes) along with its return requirements to the database. When "Approve" is clicked in the `/check` page the data in the session needs to be persisted to: - water.return_versions - water.return_requirements - water.return_requirement_points - water.return_requirement_purposes
The comment has been updated as this service is going to be used with the `GenerateReturnVersionDataService` as well as generating the data for the page that it was originally intended for
Cruikshanks
requested changes
Jul 7, 2024
app/services/return-requirements/generate-return-version-requirements.service.js
Outdated
Show resolved
Hide resolved
robertparkinson
previously approved these changes
Jul 15, 2024
| * @module PersistReturnVersionService | ||
| */ | ||
|
|
||
| const ReturnVersionModel = require('../../models/return-version.model.js') |
There was a problem hiding this comment.
NIT
Suggested change
| const ReturnVersionModel = require('../../models/return-version.model.js') | |
| const ReturnRequirementModel = require('../../models/return-requirement.model.js') | |
| const ReturnRequirementPointModel = require('../../models/return-requirement-point.model.js') | |
| const ReturnRequirementPurposeModel = require('../../models/return-requirement-purpose.model.js') | |
| const ReturnVersionModel = require('../../models/return-version.model.js') |
Jozzey
added a commit
that referenced
this pull request
Jul 31, 2024
https://eaflood.atlassian.net/browse/WATER-4568 Having worked out how to convert the information in the return requirements setup session into the various records in the DB (see #1137) we now need to deal with how the new record impacts the existing ones. This PR will extend the persisting logic to deal with changes to the existing return versions.
Jozzey
added a commit
that referenced
this pull request
Aug 9, 2024
https://eaflood.atlassian.net/browse/WATER-4568 Having worked out how to convert the information in the return requirements setup session into the various records in the DB (see #1137) we now need to deal with how the new record impacts the existing ones. This PR will extend the persisting logic to deal with changes to the existing return versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4519
Having completed the return requirements setup journey (returns-required), we need to persist both the return version (start date, reason and notes) along with its return requirements to the database.
When "Approve" is clicked in the
/checkpage the data in the session needs to be persisted to: