Remove points data created during acceptance tests #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the process of creating acceptance tests for [Copy from existing requirements](DEFRA/water-abstraction-acceptance-tests#98), we noticed the duplication of naldPointId's in the return requirements points table. After digging deeper we noticed this was occurring due to missing SQL commands in the water schema service for removing return requirement points rows relating to the running acceptance tests. As a result of this, when running the tests again, multiple duplicated points would appear on the check page, further duplicating on each run of the acceptance test 😰. This PR will add the required SQL for removing return requirement points created during the acceptance tests.
rvsiyad
changed the title
Cruikshanks
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4488
During the process of creating acceptance tests for Copy from existing requirements, we noticed the duplication of naldPointId's in the return requirements points table. After digging deeper we noticed this was occurring due to missing SQL commands in the water schema service for removing return requirement points rows relating to the running acceptance tests. As a result of this, when running the tests again, multiple duplicated points would appear on the check page, further duplicating on each run of the acceptance test 😰.
This PR will add the required SQL for removing return requirement points created during the acceptance tests.