Fix ordering of points and purposes in ret. req. #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4478 When running the acceptance tests we've created for the returns requirement setup journeys we've encountered random failures. Typically it will pass on one machine but then fail on another. We've tracked the root cause down to the fact we have not imposed an order in how we list the purposes and points during the journey. This means the test is always selecting option 1, for example, and then asserting it is 'Foo'. But depending on the machine the test is running on option 1 might have displayed as 'Bar'. This means the assertion fails. This change ensures the points and purposes in the journey are listed in a consistent controlled manor. This will fix the tests and make things better for all!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4478
When running the acceptance tests we've created for the returns requirement setup journeys, we've encountered random failures. Typically, it will pass on one machine but then fail on another.
We've tracked the root cause down to the fact we have not imposed an order in how we list the purposes and points during the journey. This means the test is always selecting option 1, for example, and then asserting it is 'Foo'. But depending on the machine the test is running on option 1 might have displayed as 'Bar'. This means the assertion fails.
This change ensures the points and purposes in the journey are listed in a consistent controlled manor. This will fix the tests and make things better for all!