Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to enable the system licence view #1130

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

jonathangoulding
Copy link
Collaborator

There are currently links directing the pages to the legacy licence view pages, built previously in the water-abstraction-ui repo. This service is slowly being replaced.

We have rebuilt these pages (with some tweaks) in this repo with the intention of using the water-abstraction-system to view and manage licences.

This change will allow us to navigate to the water-abstraction-system licence view pages instead of the 'legacy' licence view pages in a controlled manner.

This change will be mirrored in water-abstraction-ui.

https://eaflood.atlassian.net/browse/WATER-4466

There are currently links directing the pages to the legacy licence view pages, built previously in the water-abstraction-ui repo. This service is slowly being replaced.

We have rebuilt these pages (with some tweaks) in this repo with the intention of using the water-abstraction-system to view and manage licences.

This change will allow us to navigate to the water-abstraction-system licence view pages instead of the 'legacy' licence view pages in a controlled manner.

This change will be mirrored in water-abstraction-ui.

https://eaflood.atlassian.net/browse/WATER-4466
@jonathangoulding jonathangoulding added enhancement New feature or request do not merge Used for spikes and experiments labels Jun 20, 2024
@jonathangoulding jonathangoulding self-assigned this Jun 20, 2024
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of tweaks and a request: don't forget env.example! 😁

app/plugins/views.plugin.js Outdated Show resolved Hide resolved
app/plugins/views.plugin.js Outdated Show resolved Hide resolved
@jonathangoulding jonathangoulding merged commit d85fce6 into main Jun 24, 2024
6 checks passed
@jonathangoulding jonathangoulding deleted the update-legacy-view-licence-links branch June 24, 2024 15:45
@jonathangoulding jonathangoulding removed the do not merge Used for spikes and experiments label Jun 26, 2024
jonathangoulding added a commit that referenced this pull request Jun 28, 2024
When doing the original work on adding the feature flags some redirects and links where missed.

This change adds the toggle to the links / redirects picked up when in test.

https://eaflood.atlassian.net/browse/WATER-4466

Previous work - #1130
jonathangoulding added a commit that referenced this pull request Jun 28, 2024
When doing the original work on adding the feature flags some redirects and links where missed.

This change adds the toggle to the links / redirects picked up when in test.

https://eaflood.atlassian.net/browse/WATER-4466

Previous work - #1130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants