-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag to enable the system licence view #1130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently links directing the pages to the legacy licence view pages, built previously in the water-abstraction-ui repo. This service is slowly being replaced. We have rebuilt these pages (with some tweaks) in this repo with the intention of using the water-abstraction-system to view and manage licences. This change will allow us to navigate to the water-abstraction-system licence view pages instead of the 'legacy' licence view pages in a controlled manner. This change will be mirrored in water-abstraction-ui. https://eaflood.atlassian.net/browse/WATER-4466
jonathangoulding
added
enhancement
New feature or request
do not merge
Used for spikes and experiments
labels
Jun 20, 2024
Cruikshanks
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of tweaks and a request: don't forget env.example
! 😁
Cruikshanks
approved these changes
Jun 24, 2024
jonathangoulding
added a commit
that referenced
this pull request
Jun 28, 2024
When doing the original work on adding the feature flags some redirects and links where missed. This change adds the toggle to the links / redirects picked up when in test. https://eaflood.atlassian.net/browse/WATER-4466 Previous work - #1130
jonathangoulding
added a commit
that referenced
this pull request
Jun 28, 2024
When doing the original work on adding the feature flags some redirects and links where missed. This change adds the toggle to the links / redirects picked up when in test. https://eaflood.atlassian.net/browse/WATER-4466 Previous work - #1130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently links directing the pages to the legacy licence view pages, built previously in the water-abstraction-ui repo. This service is slowly being replaced.
We have rebuilt these pages (with some tweaks) in this repo with the intention of using the water-abstraction-system to view and manage licences.
This change will allow us to navigate to the water-abstraction-system licence view pages instead of the 'legacy' licence view pages in a controlled manner.
This change will be mirrored in water-abstraction-ui.
https://eaflood.atlassian.net/browse/WATER-4466