Add created_by to return versions and link models #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4522 > Part of the work to replace NALD for handling return requirements When we take control of the setup of return requirements, we'll be persisting them in the same tables that they are currently imported into. One omission though, is that there is no means to identify who created the return version. Admittedly there is nothing in NALD to indicate this hence nothing to import. But we intend to capture this information when we start persisting the records. We've [added the field to the table](DEFRA/water-abstraction-service#2567). This change makes the field available in the model, and links the return version and user models together using it.
Cruikshanks
added
the
housekeeping
Because we are editing the view rather than creating an alter migration (something we do until a migration is shipped) folks will need to perform an `npm run rollback` before then running `npm run migrate` in this repo.
Cruikshanks
requested review from
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
jonathangoulding
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4522
When we take control of the setup of return requirements, we'll be persisting them in the same tables that they are currently imported into.
One omission is that there is no means to identify who created the return version. Admittedly, there is nothing in NALD to indicate this, so there is nothing to import. But we intend to capture this information when we start persisting the records.
We've added the field to the table. This change makes the field available in the model, and links the return version and user models together using it.