Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation msg for ret. req. copy existing #1125

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

Cruikshanks
Copy link
Member

@Cruikshanks Cruikshanks commented Jun 19, 2024

https://eaflood.atlassian.net/browse/WATER-4283

In Update validation msg for ret. req. copy existing we updated the validation message if a user doesn't select an option in the copy existing return requirements page to "Select a previous requirements for returns".

Our design team, however, was originally going to use "Select a return version". Having seen the updated text in 'the flesh', they've decided to go with their original plan.

This change sets the validation message to "Select a return version".

https://eaflood.atlassian.net/browse/WATER-4283

In [Update validation msg for ret. req. copy existing](#1112) we updated the validation message if a user doesn't select an option in the copy existing return requirements page to "Select a previous requirements for returns".

Our design team however were originally going to use "Select a return version". Having seen the updated text it in the flesh, they've decided to go with their original plan.

This change sets the validation message to be "Select a return version".
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Jun 19, 2024
@Cruikshanks Cruikshanks self-assigned this Jun 19, 2024
@Cruikshanks Cruikshanks marked this pull request as ready for review June 19, 2024 16:54
@Cruikshanks Cruikshanks merged commit 0ce889a into main Jun 19, 2024
6 checks passed
@Cruikshanks Cruikshanks deleted the update-validation-msg-again branch June 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant