Add charging model to review model relationships #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4196 > Part of the work for two-part tariff annual billing Our billing engines work on the basis of starting by selecting the appropriate billing accounts, then the data needed to generate bills for them. This means we are going from charging information (charge versions, references and elements) _to_ review information (also charge versions, references and elements!) When we created the review models we included the relationships to link them to charging information. But we didn't do the same on the charging side. In order to generate the bills we need to be able to link from that direction hence this change.
Cruikshanks
added
the
housekeeping
Cruikshanks
requested review from
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4196
Our billing engines work on the basis of starting by selecting the appropriate billing accounts, then the data needed to generate bills for them.
This means we are going from charging information (charge versions, references and elements) to review information (also charge versions, references and elements!)
When we created the review models, we included the relationships to link them to charging information. But we didn't do the same on the charging side.
In order to generate the bills, we need to be able to link from that direction, hence this change.