Fix model migrations since last release #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Warning! This will break local environments unless you manually remove existing tables and views in the `public` schema. We've been doing work for both return requirements and two-part tariff that has resulted in a number new migrations being added and existing ones being edited. However, because these 2 features are large, complex and constantly in flux we've often needed to make changes. Or, we simply got it wrong and the original migrations was incorrect. We've just spotted that a recent attempt to fix a migration actually ended up reverting an earlier fix! We've always had a policy that migrations are not 'fixed' until they are shipped to production. So, we're taking a pause and tidying up the currently 'unshipped' migrations. This means for example, where we have created a migration, then altered it a number of times that those alterations will be added to the original `create` then deleted. We'll also take the opportunity to get the files names back on track with what they should be.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been doing work on both return requirements and two-part tariff which has resulted in a number of new migrations being added and existing ones being edited.
However, because these 2 features are large, complex, and constantly in flux, we've often needed to make changes. Or, we simply got it wrong, and the original migrations were incorrect.
We've just spotted that a recent attempt to fix a migration actually ended up reverting an earlier fix! We've always had a policy that migrations are not 'fixed' until they are shipped to production. So, we're taking a pause and tidying up the currently 'unshipped' migrations.
This means, for example, that if we created a migration, then altered it a number of times, those alterations will be added to the original
createthen deleted.We'll also take the opportunity to get the file names back on track with what they should be plus fix and 'miss-typed' relationships.