Feature view requirements for returns #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket - https://eaflood.atlassian.net/browse/WATER-4422 Adds a new page to allow users to view the requirements for returns. A user can click a view link on the licence setup tab under the requirements for returns. This page is similar to previous work done on the requirements for returns check page.
jonathangoulding
requested review from
Cruikshanks,
Beckyrose200,
rvsiyad and
Jozzey
and removed request for
Cruikshanks and
Beckyrose200
Cruikshanks
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Started adding specific comments but realised there was going to be quite a few!
But I think its because the needs for the return requirement setup journey have gotten mixed in with this. Whereas I think we can simplify things when just taking the completed record and presenting it.
This will be quicker and easier to pair on and discuss. So, we'll arrange that offline from here and progress there.
app/services/return-requirements/fetch-requirements-for-returns.service.js
Show resolved
Hide resolved
|
New PR created based on changes required - #1118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket - https://eaflood.atlassian.net/browse/WATER-4422
Adds a new page to allow users to view the requirements for returns.
A user can click a view link on the licence setup tab under the requirements for returns.
This page is similar to previous work done on the requirements for returns check page.