Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix No returns required missing notification banner #1104

Merged

Conversation

jonathangoulding
Copy link
Collaborator

@jonathangoulding jonathangoulding commented Jun 13, 2024

https://eaflood.atlassian.net/browse/WATER-4386

Part of the work to replace NALD for handling return requirements

When a user changes the reason for a no-returns requirement, a flash notification should be displayed on the requirements check page highlighting that an update has been made.

The other pages were done in Add flash notification when changes occur on returns Requirements but this one was missed.

When a user changes the reason for a no returns requirement then the update notification banner should be displayed on the requirements check page.

Ticket - https://eaflood.atlassian.net/jira/software/c/projects/WATER/boards/96?selectedIssue=WATER-4386

AC 4 states the no returns required page needs to show the same update message when the reason is changed.

Previous work / pr - #1079
@jonathangoulding jonathangoulding added the bug Something isn't working label Jun 13, 2024
@jonathangoulding jonathangoulding self-assigned this Jun 13, 2024
@jonathangoulding jonathangoulding marked this pull request as ready for review June 13, 2024 15:43
@jonathangoulding jonathangoulding merged commit cac0e8f into main Jun 13, 2024
6 checks passed
@jonathangoulding jonathangoulding deleted the fix-missing-notification-banner-for-no-returns-required branch June 13, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants