Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding acceptance test tags for no returns journey #1093

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

rvsiyad
Copy link
Contributor

@rvsiyad rvsiyad commented Jun 12, 2024

https://eaflood.atlassian.net/browse/WATER-4484

This PR is focused on adding tags needed to target elements of the no return requirements journey.

To make it easier to locate the elements on the page we want to test, we add tags like so:

'<span data-test="reason">' + reason + '</span>'

This will target the reason element and allow us to compare its contents against an expected value entered previously.

It builds upon the work completed in a previous PR - 1043.

https://eaflood.atlassian.net/browse/WATER-4484

This PR is focused on adding tags needed to target elements of the no return requirements journey.

It builds upon the work completed in a previous[PR - 1043](#1043).
@rvsiyad rvsiyad added the housekeeping Refactoring, tidying up or other work which supports the project label Jun 12, 2024
@rvsiyad rvsiyad self-assigned this Jun 12, 2024
@rvsiyad rvsiyad marked this pull request as ready for review June 12, 2024 13:54
@rvsiyad rvsiyad merged commit bcbc5d7 into main Jun 12, 2024
6 checks passed
@rvsiyad rvsiyad deleted the no-returns-required-acceptance-tags branch June 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants