Amend no returns message in view licence Returns tab #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a licence has returns show the returns table. When the licence does not have returns and or requirements then the messages show need to show different messages.
app/services/licences/fetch-licence-has-requirements.service.js
Outdated
Show resolved
Hide resolved
Cruikshanks
changed the title
Cruikshanks
requested changes
Jun 12, 2024
app/services/licences/fetch-licence-has-requirements.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/fetch-licence-has-requirements.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/fetch-licence-has-requirements.service.js
Outdated
Show resolved
Hide resolved
use njk component for table
Cruikshanks
requested changes
Jun 12, 2024
app/services/licences/determine-licence-has-return-versions.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/determine-licence-has-return-versions.service.js
Outdated
Show resolved
Hide resolved
test/services/licences/determine-licence-has-return-versions.service.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
…rvice.js Co-authored-by: Alan Cruikshanks <[email protected]>
…rvice.js Co-authored-by: Alan Cruikshanks <[email protected]>
…rvice.js Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
…no-returns-message' into feature-licence-returns-summary-no-returns-message
…ervice.test.js Co-authored-by: Alan Cruikshanks <[email protected]>
jonathangoulding
deleted the
feature-licence-returns-summary-no-returns-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4461
A licence can be linked to both return versions and return submissions. However, currently, the two are not generated at the same time. Plus, it is valid that a licence has neither.
We want to make the messaging more informative so this change amends the message we show when there are no returns.