Exclude not-required rtn versions from copy exist #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4283 > Part of the work to replace NALD for handling return requirements We want to be able to offer users the option to copy data from an existing return requirement when setting up a new one. We [made the option available](#1081) in the `/setup` page. We then implemented the logic to fetch the existing data and transform it into a something that can be stored in the session for later persisting back as a new record. One of the new features we're enabling with our takeover is the ability to record where a return requirement is _not_ needed. Our new journey allows for this. When this happens though, we'll need to persist a return version to record it. It will be 'current' but it will have no return requirements linked to it. Because of this we need to tweak the query which fetches which return versions can be copied from to exclude those without any return requirements.
This includes the one we expect to fail at the moment; a current return version without any return requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4283
We want to be able to offer users the option to copy data from an existing return requirement when setting up a new one. We made the option available in the
/setuppage.We then implemented the logic to fetch the existing data and transform it into something that can be stored in the session for later persisting as a new record.
One of the new features we're enabling with our takeover is the ability to record where a return requirement is not needed. Our new journey allows for this.
When this happens, though, we'll need to persist a return version to record it. It will be 'current' but it will have no return requirements linked to it.
Because of this, we need to tweak the query that fetches which return versions can be copied from to exclude those without any return requirements.