Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-part tariff review pages - Removing validation #1084

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-4497

During the testing for the two-part tariff review pages, it was found that some of the validation on the amend pages where too restrictive. The volumes or adjustments entered both had minimum and maximum values set. The billing and data team after testing the engine found these to be too restrictive and they needed the ability to go higher than the max amount. This PR removes the validation for the range that a user can enter.

https://eaflood.atlassian.net/browse/WATER-4497

During the testing for the two-part tariff review pages, it was found that some of the validation on the amend pages where too restrictive. The volumes or adjustments entered both had minimum and maximum values set. The billing and data team after testing the engine found these to be too restrictive and they needed the ability to go higher then the max amount.
This PR is removing the validation for the range that a user can enter.
@Beckyrose200 Beckyrose200 added the enhancement New feature or request label Jun 10, 2024
@Beckyrose200 Beckyrose200 self-assigned this Jun 10, 2024
@Beckyrose200 Beckyrose200 marked this pull request as ready for review June 10, 2024 15:16
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beckyrose200 Beckyrose200 merged commit 353c341 into main Jun 10, 2024
6 checks passed
@Beckyrose200 Beckyrose200 deleted the two-part-tariff-removing-validation branch June 10, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants