Tidy up the file names of legacy migrations #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
This is just a simple housekeeping to keep things in order. The legacy migrations are purely used when creating the test database. They support our unit tests because we have chosen not to stub out the DB layer. We went through an exercise of grouping the migrations by schema so that we can more easily see what legacy tables we have migrations for. However, we've let that slide recently. And, whilst we are fixing filenames we're also updating them all to separate the timestamp from the given name with an underscore. This is what would happen if you created the migration the normal way.
Cruikshanks
force-pushed
the
tidy-legacy-migrations
branch
from
3b9c846 to
bd9c048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some simple housekeeping to keep things in order.
The legacy migrations are purely used when creating the test database. They support our unit tests because we have chosen not to stub out the DB layer.
We went through an exercise of grouping the migrations by schema so that we can more easily see what legacy tables we have migrations for. However, we've let that slide recently.
And, while we are fixing filenames, we're also updating them all to separate the timestamp from the given name with an underscore. This is what would happen if you created the migration the normal way.