Adding tags to view for acceptance tests (returns) #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4485 When writing acceptance tests, due to the way [crypress](https://docs.cypress.io/guides/overview/why-cypress) works, some components of a page can be hard to locate. For example, imagine a summary list which has nested values. This might be the address on the page provided by cypress: ``` ':nth-child(2) > .govuk-summary-list.govuk-\!-margin-bottom-2 > :nth-child(1) > .govuk-summary-list__value' ``` To make it easier to locate the elements on the page we want to test, we add tags like so: ``` '<span data-test="meta-data-reason">' + reason + '</span>' ``` This PR is focused on adding tags to the views in the returns required journey.
rvsiyad
added
the
housekeeping
….com/DEFRA/water-abstraction-system into return-required-acceptance-test-tags
Cruikshanks
requested changes
Jun 7, 2024
….com/DEFRA/water-abstraction-system into return-required-acceptance-test-tags
…meta-data" prefix from test tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4485
When writing acceptance tests, due to the way crypress works, some components of a page can be hard to locate.
For example, imagine a summary list which has nested values. This might be the address on the page provided by cypress:
To make it easier to locate the elements on the page we want to test, we add tags like so:
This PR is focused on adding tags to the views in the returns required journey as well as adding more points to the permit licence helper to provide 2 points for the return requirement points page.