Fix CHA CreateBillRunService result parsing #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3833 Found when working on [Add GlobalNotifier to the app](#100). If we get an error response from the [SROC Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) we are able to parse the result without issue. This is because it will have a JSON body. But if Got throws an exception, which it will do if it fails to get a response, for example, when the request times out then `result.response` won't have a `body` property. This is causing the `_parseResult()` method to throw an error; `Unexpected token u in JSON at position 0`. This change updates `_parseResult()` in `CreateBillRunService` to be able to handle both scenarios.
> Remove this useless assignment to variable "response".
StuAA78
requested changes
Jan 31, 2023
Co-authored-by: Stuart Adair <[email protected]>
StuAA78
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3833
Found when working on Add GlobalNotifier to the app. If we get an error response from the SROC Charging Module API we are able to parse the result without issue. This is because it will have a JSON body.
But if Got throws an exception, which it will do if it fails to get a response, for example, when the request times out then
result.responsewon't have abodyproperty.This is causing the
_parseResult()method to throw an error;Unexpected token u in JSON at position 0.This change updates
_parseResult()inCreateBillRunServiceto be able to handle both scenarios.