Fix user seeding not creating user groups #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3981 The [water-abstraction-service](https://gitub.com/DEFRA/water-abstraction-service) has a mechanism for seeding data for testing that relies on loading in YAML fixture files, sort of. Some content comes from these but other stuff is hard-coded into the 'loaders'. Long story short we're going to replace it with something simpler yet more flexible. We initially were going to use [Knex's seeding functionality](https://knexjs.org/guide/migrations.html#seed-files) to generate the data. But we've had a change of mind (look out for `/data/load` coming in a future change!) We still need users though and we can simplify things in our acceptance tests if they can assume the different types of users have been created. That's when we spotted this isn't actually working! 🤦 It is creating the users but not linking them to the groups that give them the permissions needed. This change fixes the user seed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3981
The water-abstraction-service has a mechanism for seeding data for testing that relies on loading in YAML fixture files, sort of. Some content comes from these, but other stuff is hard-coded into the 'loaders'.
Long story short we're going to replace it with something simpler yet more flexible. We initially were going to use [Knex's seeding functionality] (https://knexjs.org/guide/migrations.html#seed-files) to generate the data.
But we've had a change of mind (look out for
/data/loadcoming in a future change!) We still need users though and we can simplify things in our acceptance tests if they can assume the different types of users have been created.That's when we spotted this isn't actually working! 🤦
It is creating the users but not linking them to the groups that give them the permissions needed. This change fixes the user seed.