Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate and display expected charge during 2PT review #1036

Merged
merged 9 commits into from
May 23, 2024

Conversation

Jozzey
Copy link
Contributor

@Jozzey Jozzey commented May 20, 2024

https://eaflood.atlassian.net/browse/WATER-4446

Add functionality to the Review Charge Reference page to allow the user to preview the charge for the Charge Reference.

The preview of the charge will be triggered by a button on the Review Charge Reference details page and will display the result in a banner at the top of the screen.

This is the first of two PRs. In this PR a new Charging Module "request" is being added to enable a request to be sent to the Charging Module to calculate a charge. The next PR covered by ticket https://eaflood.atlassian.net/browse/WATER-4441 will add functionality to the screens to enable a charge to be calculated for a charge reference.

https://eaflood.atlassian.net/browse/WATER-4441

Add functionality to the Review Charge Reference page to allow the user to preview the charge for the Charge Reference.

The preview of charge will be triggered by a button on the Review Charge Reference details page, and will display the result in a banner at the top of the screen.
@Jozzey Jozzey added the enhancement New feature or request label May 20, 2024
@Jozzey Jozzey self-assigned this May 20, 2024
@Jozzey Jozzey marked this pull request as ready for review May 20, 2024 15:56
@Jozzey Jozzey requested a review from Cruikshanks May 23, 2024 08:54
@Jozzey Jozzey requested a review from Beckyrose200 May 23, 2024 09:44
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I just ask that you update the PR title before merging? It makes it sound like this is all the work, when in fact we are just adding the supporting charging module API request.

@Jozzey Jozzey merged commit e51889f into main May 23, 2024
6 checks passed
@Jozzey Jozzey deleted the calc-tpt-expected-charge branch May 23, 2024 09:55
Jozzey added a commit that referenced this pull request May 23, 2024
https://eaflood.atlassian.net/browse/WATER-4441

Add functionality to the Review Charge Reference page to allow the user to preview the charge for the Charge Reference.

The preview of the charge will be triggered by a button on the Review Charge Reference details page and will display the result in a banner at the top of the screen.

This is the second of two PRs. In the previous PR #1036 a new Charging Module "request" was added to enable a request to be sent to the Charging Module to calculate a charge.

This PR will cover adding the functionality to the screens to enable a charge to be calculated and displayed for a charge reference.
Jozzey added a commit that referenced this pull request May 31, 2024
https://eaflood.atlassian.net/browse/WATER-4441

Add functionality to the Review Charge Reference page to allow the user to preview the charge for the Charge Reference.

The preview of the charge will be triggered by a button on the Review Charge Reference details page and will display the result in a banner at the top of the screen.

This is the second of two PRs. In the previous PR #1036 a new Charging Module "request" was added to enable a request to be sent to the Charging Module to calculate a charge.

This PR will cover adding the functionality to the screens to enable a charge to be calculated and displayed for a charge reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants