Fix view licence summary for incomplete licences #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4322 In testing we have found licences that have incomplete information. For example, `28/39/29/0048C` has no contacts, not even a licence holder, nor any licence version records. The data doesn't appear to exist in the NALD extract we receive so we have nothing we can use to fill in the missing pieces. But we don't want our licence summary to break when a user searches for the licence, then clicks through. So, these changes ensure the page _shouldn't_ error when a user selects one of these incomplete licences.
Update the FetchLicenceAbstractionConditionsService to handle being passed an undefined licence version ID which will happen if the licence is incomplete and missing version records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4322
In testing, we have found licences that have incomplete information. For example,
28/39/29/0048Chas no contacts, not even a licence holder, nor any licence version records.The data doesn't appear to exist in the NALD extract we receive, so we have nothing we can use to fill in the missing pieces. But we don't want our licence summary to break when a user searches for the licence and then clicks through.
So, these changes ensure the page shouldn't error when a user selects one of these incomplete licences.