Refactor purposes page to use purpose ids as values #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
requested changes
May 16, 2024
test/services/return-requirements/fetch-licence-purposes.service.test.js
Outdated
Show resolved
Hide resolved
test/services/return-requirements/fetch-licence-purposes.service.test.js
Outdated
Show resolved
Hide resolved
test/services/return-requirements/submit-purpose.service.test.js
Outdated
Show resolved
Hide resolved
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4294
As part of our work to get the requirements for returns set up we need to know which of the purposes the user has selected in the manual journey so that we can then get the information later at the check your answers page.
This PR changes the logic to store the ID rather than the string which describes the purpose. that way we can look it up again.