Alter 2PT Review Licences filter behaviour #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4462 Currently the filter data that is held in the cookie for the "Review Licences" page will persist each time the user accesses the page, regardless of which 2PT bill run they are reviewing. This is not desirable behaviour, so in this PR the cookie data will now include the `billRunId` to which it relates so that it is only persisted for the bill run that the user set the filter on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4462
Currently, the filter data that is held in the cookie for the "Review Licences" page will persist each time the user accesses the page, regardless of which 2PT bill run they are reviewing.
This is not desirable behaviour. So in this PR the identifier for the cookie data will now include the
billRunIdto which it relates so it only persists data for the bill run the user set the filter on.