Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove returns requirements button on check page #1021

Merged
merged 11 commits into from
May 16, 2024

Conversation

rvsiyad
Copy link
Contributor

@rvsiyad rvsiyad commented May 15, 2024

https://eaflood.atlassian.net/browse/WATER-4304

When setting up a requirement for returns, a user can now add multiple requirements. As a result of being able to add more requirements, errors can occur where unwanted requirements have been added to a return.

Users need the flexibility to remove a single requirement on the check page without having to cancel the entire return through the Cancel these return requirements button. Users must also be notified of the removed requirement when redirected to the check page.

This PR expands on Remove these return requirements and implements a button to redirect users to the remove page where requirements can be removed one by one. Yar notifications are also added in this PR to notify users of a successfully removed requirement.

https://eaflood.atlassian.net/browse/WATER-4304

When setting up a requirement for returns, a user can now add multiple
requirements. As a result of being able to add more requirements, errors can occur
where unwanted requirements have been added for a return.

Users need the flexibility to remove a single requirement on the check page without having to cancel the
entire return through the [Cancel these return requirements] (https://eaflood.atlassian.net/browse/WATER-4302) button.

This PR expands on [Remove these return requirements] (https://eaflood.atlassian.net/browse/WATER-4304
) and implements a button to redirect users to the remove page where requirements can be removed one by one.
@rvsiyad rvsiyad added the enhancement New feature or request label May 15, 2024
@rvsiyad rvsiyad self-assigned this May 15, 2024
@rvsiyad rvsiyad marked this pull request as ready for review May 16, 2024 14:10
@rvsiyad rvsiyad merged commit dd92b8c into main May 16, 2024
6 checks passed
@rvsiyad rvsiyad deleted the remove-return-requirement-button branch May 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants