-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scheduled Notifications model #1018
Merged
jonathangoulding
merged 8 commits into
main
from
feature-add-scheduled-notifications-model
May 15, 2024
Merged
Add Scheduled Notifications model #1018
jonathangoulding
merged 8 commits into
main
from
feature-add-scheduled-notifications-model
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The communication tab on the view licence page need to get the scheduled notification in order o render a list of communications. Scheduled notifications for the communications tab appear to need the events table data to help render the information with context. The schedule notification model has been added to handle the interaction with the database.
…ithub.com/DEFRA/water-abstraction-system into feature-add-scheduled-notifications-model
Cruikshanks
changed the title
Feature add scheduled notifications model
Add Scheduled Notifications model
May 15, 2024
Cruikshanks
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the notes regarding the legacy migration which obviously you could have done with before, not after starting this PR 😬
db/migrations/legacy/20240515104554_water-add-scheduled-notifications.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4315
The 'Communications' tab on the view licence page needs to get the 'sent' scheduled notifications linked to a licence in order to render a list of communications.
The data in the legacy communications tab depends on
water.events
table data. Events are linked to scheduled notifications.So, this change adds the new model and sets a link between it and the
EventModel
.