Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scheduled Notifications model #1018

Merged
merged 8 commits into from
May 15, 2024

Conversation

jonathangoulding
Copy link
Collaborator

@jonathangoulding jonathangoulding commented May 15, 2024

https://eaflood.atlassian.net/browse/WATER-4315

Part of work to replace the legacy view licence page

The 'Communications' tab on the view licence page needs to get the 'sent' scheduled notifications linked to a licence in order to render a list of communications.

The data in the legacy communications tab depends on water.events table data. Events are linked to scheduled notifications.

So, this change adds the new model and sets a link between it and the EventModel.

The communication tab on the view licence page need to get the scheduled notification in order o render a list of communications.

Scheduled notifications for the communications tab appear to need the events table data to help render the information with context.

The schedule notification model has been added to handle the interaction with the database.
@jonathangoulding jonathangoulding self-assigned this May 15, 2024
@jonathangoulding jonathangoulding marked this pull request as ready for review May 15, 2024 12:42
@Cruikshanks Cruikshanks added the enhancement New feature or request label May 15, 2024
@Cruikshanks Cruikshanks changed the title Feature add scheduled notifications model Add Scheduled Notifications model May 15, 2024
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the notes regarding the legacy migration which obviously you could have done with before, not after starting this PR 😬

@jonathangoulding jonathangoulding merged commit 41c0a1d into main May 15, 2024
6 checks passed
@jonathangoulding jonathangoulding deleted the feature-add-scheduled-notifications-model branch May 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants