Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update points page to use point id as the value #1016

Merged
merged 5 commits into from
May 15, 2024

Conversation

robertparkinson
Copy link
Collaborator

@robertparkinson robertparkinson commented May 14, 2024

https://eaflood.atlassian.net/browse/WATER-4295

As part of our work to get the requirements for returns set up we need to know which of the points the user has selected in the manual journey so that we can then get the information later at the check your answers page.

This PR changes the logic to store the ID rather than the string which describes the point. that way we can look it up again.

@robertparkinson robertparkinson marked this pull request as ready for review May 14, 2024 15:26
@Cruikshanks Cruikshanks changed the title update points page to use point id as the value Update points page to use point id as the value May 14, 2024
@robertparkinson robertparkinson merged commit d2bced8 into main May 15, 2024
6 checks passed
@robertparkinson robertparkinson deleted the return-requirements-manual-point-details branch May 15, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants