Adding multiple return requirements to the session #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is focused on allowing users to add another return requirement to the current session once they have reached the check page in the journey. Users will be redirected to the purpose page for the new requirement.
…completed one requirement
rvsiyad
requested review from
Demwunz,
Cruikshanks,
robertparkinson,
Jozzey and
Beckyrose200
Cruikshanks
removed request for
Demwunz,
robertparkinson,
Jozzey and
Beckyrose200
Cruikshanks
requested changes
May 15, 2024
…github.com/DEFRA/water-abstraction-system into return-requirement-adding-multiple-returns
Cruikshanks
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4386
When setting up 'requirements for returns', a user can set up multiple requirements (it's why we call it 'requirements for returns' not 'requirement for returns'!
Unfortunately, the wording for this feature isn't helpful to us dev's. So, when a user opts to setup a new 'requirements for returns' we actually create a return version. Against that we'll record the start date, reason, a note (optional) and any additional agreements.
Under that must be at least 1 return requirement. Against that we record details like the purpose, point, site description etc.
But users need flexibility. For example, suppose a licence is granted to abstract water for 2 different purposes. We may require separate returns for each purpose. In this case, we only need 1 return version, for example, 'new licence'. But we need 2 separate return requirements in order to detail the 2 different return submissions we'll expect.
In Add support for multiple rtn. reqs. plus tidy up we updated the session handling and journey to support working with multiple return requirements.
This change is allows users to add and additional requirements to the session and set them up once they have reached the
/checkpage in the journey. When a user clicks the add button, they'll be redirected to the/purpose/{new requirements index}page after we've inserted a new blank requirement in the session.