Determine if licence is 'billed' #101
Conversation
https://eaflood.atlassian.net/browse/WATER-3868 We need to know whether a licence has already been ‘billed’ in the current period. If so we’ll have to ensure it’s credited as part of the bill run before we recalculate the debit. For each licence that is a candidate for billing, we need to determine if it was included in a billing_batch for the current period.
| @@ -24,7 +24,7 @@ describe('Check Live Bill Run service', () => { | |||
| describe('when an sroc supplementary bill run exists for this region and financial year', () => { | |||
| describe('with a status considered to be "live"', () => { | |||
| beforeEach(async () => { | |||
| billRun = await BillingBatchHelper.add() | |||
| billRun = await BillingBatchHelper.add({ status: 'queued' }) | |||
There was a problem hiding this comment.
Going to comment here but also applies to line 39 in the same file and the change to test/support/helpers/water/billing-batch.helper.js.
queued is the default state for a new BillingBatch record and that is why the helper uses that as its default. Is there a reason why we have switched the default to sent?
There was a problem hiding this comment.
I defaulted it to sent as there was only 2 tests that used that default value queued. As the majority of the tests use the status of sent I found the helper to be much more helpful if this was the default.
There was a problem hiding this comment.
I think I'd still argue that the default matches with what would happen when the record is newly created and that we then apply the status we need in the tests.
It might be we have more tests that use 'sent' now. But that might change in the future. Plus, the status being sent is important in these tests whereas it might be meaningless in others. So, IMHO it's better to set the state where it matters. 🤷
There was a problem hiding this comment.
You've talked me round 😁 I shall change the default back to queued
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
test/services/supplementary-billing/fetch-licences.service.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
https://eaflood.atlassian.net/browse/WATER-3868
We need to know whether a licence has already been ‘billed’ in the current period. If so we’ll have to ensure it’s credited as part of the bill run before we recalculate the debit.
For each licence that is a candidate for billing, we need to determine if it was included in a billing_batch for the current period.